Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[actpool] fix typo for worker queue #4028

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[actpool] fix typo for worker queue #4028

merged 3 commits into from
Jan 2, 2024

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Dec 20, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 532 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (501eb02) 76.26%.
Report is 133 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
blockindex/sgd_indexer.go 90.30% 12 Missing and 7 partials ⚠️
... and 30 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4028      +/-   ##
==========================================
+ Coverage   75.38%   76.26%   +0.88%     
==========================================
  Files         303      331      +28     
  Lines       25923    28281    +2358     
==========================================
+ Hits        19541    21569    +2028     
- Misses       5360     5615     +255     
- Partials     1022     1097      +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dustinxie
dustinxie reviewed Dec 26, 2023
View reviewed changes
actpool/config.go Outdated
@@ -13,7 +13,8 @@ var (
DefaultConfig = Config{
MaxNumActsPerPool: 32000,
MaxGasLimitPerPool: 320000000,
MaxNumActsPerAcct: 2000,
MaxNumActsPerAcct: 500,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 500 the current default value used on mainnet nodes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iotexproject/iotex-core/pull/4028/files#diff-a8abac2771195f422f421ee3179639574be3f78960621421a3d5189e8f1bde14L144

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dustinxie dustinxie merged commit d1ec200 into iotexproject:master Jan 2, 2024
4 of 5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envestcc envestcc envestcc approved these changes

@dustinxie dustinxie dustinxie approved these changes

@CoderZhi CoderZhi Awaiting requested review from CoderZhi CoderZhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liuhaai @dustinxie @envestcc